ui/on-call notifications: always show quick link, show error on no days

target / goalert

Open source on-call scheduling, automated escalations, and notifications so you never miss a critical alert

https://goalert.me

Apache License 2.0

2.17k stars 230 forks source link

Closed Forfold closed 1 month ago

Forfold commented 1 month ago

This PR makes a couple small changes to the Schedule On-Call Notifications experience:

The quick link from the Schedule page should always show now. This was previously conditionally rendered if slack or webhooks were enabled in the config
Shows an error and disables the user from submitting if "Specify at time and day of week" is enabled, but all days are unchecked, saying that at least one day is required. Right now, nothing happens and the dialog closes.

Screenshot 2024-05-20 at 1 37 21 PM