target / grease

Automated Scripting Engine For the Modern Age
https://grease.readthedocs.io
MIT License
42 stars 22 forks source link

default value for configuration should be an empty dict #84

Closed chollinger closed 6 years ago

chollinger commented 6 years ago

GREASE Developer Pull Request Checklist replace with your PR title

USE THIS TEMPLATE FOR YOUR PULL REQUEST!

Purpose

The default value for the GREASE config global was None. This led to Errors when attempting to index with .get with a default value if the global config was inaccessible or not configured (such as when tests were run locally, as there should be no need for a configuration to be present for that). Making the default an empty dict fixes this issue, and is more correct in my opinion.

Expected Outcome

Global configuration defaults to an empty dict.

Checklist

abstract-base-method commented 6 years ago

Nice catch my friend!