target / pod-reaper

Rule based pod killing kubernetes controller
MIT License
200 stars 52 forks source link

Docker builds no longer happening automatically #72

Closed brianberzins closed 2 years ago

brianberzins commented 3 years ago

@slushpupie With recent changes to docker's licensing, the automated builds are now a payed feature. It doesn't look like I have permissions to upload new builds myself, and I was previously relying on the automated builds.

Do you have thoughts on this? I'm pretty upset with Docker's license changes overall, but I'll have to find time to pickup podman or an alternative. Is there a reasonable thing to do in the meantime?

slushpupie commented 3 years ago

We (Target) are working on what to do at this point. I'll get back to you on this once we have that figured out (hopefully in short order)

brianberzins commented 2 years ago

Not perfectly clear on this, but given this is open sourced, I might be able to setup github actions. Would need someone on the Target side to inject a working token to do the docker push.

brianberzins commented 2 years ago

@slushpupie got a chance to play around with github actions tonight, and have a build working over on a fork. Having done some work with ci tools in the past, I have a paranoid nagging about the security of secrets happening that I want to make sure is actually closed. If it is, I think it's a solid option. Otherwise, I'll post an update here.

More to come.

slushpupie commented 2 years ago

Sorry, I've been meaning to get back to you on this. I am working out how to get our service accounts on our Docker Hub account, and once we get that complete, we will have a secret stored at github.com/target for publishing docker images.

brianberzins commented 2 years ago

Awesome! Thanks!