search

target / portauthority

API that leverages Clair to scan Docker Registries and Kubernetes Clusters for vulnerabilities
Other
151 stars 21 forks source link

Fix case-sensitivity with sirupsen/logrus #7

Closed caipre closed 6 years ago

caipre commented 6 years ago

Presently, make deps fails because of this package:

[INFO]  --> Fetching updates for github.com/Sirupsen/logrus
[ERROR] Update failed for github.com/Sirupsen/logrus: The Remote does not match the VCS endpoint
[ERROR] Failed to install: The Remote does not match the VCS endpoint

Per the logrus repository readme,

Everything using logrus will need to use the lower-case: github.com/sirupsen/logrus

This change does that.

caipre commented 6 years ago

Hmm, looks like glide.yaml pins to a specific version of docker/distribution that doesn't include https://github.com/docker/distribution/commit/a97d7c0c155be14d1380c075d3197a5d89c2abc2 . In fact, that commit isn't in the latest release (v2.6.2). I'll try building at that commit, since it's required.

ErikThoreson commented 6 years ago

@caipre it should still work with the upper case version of those pinned versions. the docker registry client library required that version for the moment and that required the upper case stuff everywhere too.

have you tried running a glide cc prior to the make deps?

PS: on the dockerbuilder branch I'm removing the make deps option from the readme and including the glide steps in the docker build itself so we can more easily publish an image to docker hub.

caipre commented 6 years ago

have you tried running a glide cc prior to the make deps?

After some more playing around I did reach that point. I have other projects that do use the lower-case version though, and having to clear the cache each time will be painful. I've pushed a new commit that fixes the problems for me at the cost of tracking unreleased versions of docker/distribution. Let me know what you think.

ErikThoreson commented 6 years ago

thanks - I'm going to test it out a bit but I don't see any issue with this

ErikThoreson commented 6 years ago

everything tests good. the only trouble I had was it looks like the glick.lock and the glide.yaml were out of sync based on the warning in the travis run

i went to run a glide update and ran into this error:

[WARN] --> Unable to find semantic version for constraint github.com/opencontainers/go-digest ^1.0.0

it looks like github.com/opencontainers/go-digest doesn't have that version yet. I set it to '^1.0.0-rc1` then ran the glide update and things worked well.

could you update the glide.yml with this change and run an update? then i think we're good.

caipre commented 6 years ago

Odd, I ran make deps and make deploy-minikube locally and everything went through. I did run glide update -v as well, IIRC. Anyway, I'll make the change.