target / strelka

Real-time, container-based file scanning at enterprise scale
Other
878 stars 113 forks source link

Fixed bug where tasks wouldn't process if ID was included in the request #380

Closed nighttardis closed 1 year ago

nighttardis commented 1 year ago

Describe the change When a request includes their own ID, backend container are unable to find the event and data entries in Redis. This is because the keys for both the even and data are set with a UUID generated by the frontend, but when submitting the tasks the ID will the the one provided by the request. This update will update the event and data keys before they are submitting to Redis if an ID exists in the request.

Describe testing procedures Ran the sample python client included in this repo.

Sample output If this change modifies Strelka's output, then please include a sample of the output here.

Checklist

phutelmyer commented 1 year ago

@nighttardis Great find! Thanks for troubleshooting and writing this PR up. I'll review it locally today. 👍

phutelmyer commented 1 year ago

Tested locally, works as expected. Thank you for your contribution @nighttardis!