target / strelka

Real-time, container-based file scanning at enterprise scale
Other
878 stars 113 forks source link

[BUG] ScanQR Type Assertions #404

Closed phutelmyer closed 1 year ago

phutelmyer commented 1 year ago

Describe the bug When reviewing ScanQR events, it was observed that the type field often had the value "undefined." Furthermore, there were numerous URLs in the collection that were not included in the ScanQR URL regex. This has raised concerns about the reliability and relevance of the "type" field in ScanQR results.

The primary concern here is whether it is appropriate to continue attempting to assert a "type" for QR codes. Given the nature of QR codes, which can encode a wide variety of data types (URLs, text, contact information, etc.), it might not be practical to accurately determine a specific "type" for every QR code.

Proposed recommendation is to remove the type field rather than try to ensure it is continuously updated with possible permutations.

Environment details N/A

Pytest Output N/A

phutelmyer commented 1 year ago

Fixed in #406 by @ryanohoro.