tari-labs / tari-university

Tari Labs University is an open source, curated set of materials developed by the Tari Community to help facilitate knowledge transfer and education.
187 stars 49 forks source link

R1cs bulletproofs final edits da #244

Closed anselld closed 4 years ago

anselld commented 4 years ago

Hi @hansieodendaal and @Empiech007 This looks good. I only have one question, please. In Table 3, No. 6, it is unclear what creates its own transcript. All the links work, as well as the contents. Please let me have your comments. Thanks and regards.

anselld commented 4 years ago

Hi @hansieodendaal and @Empiech007

Another question and observation:

  1. In the last sentence under Conclusions, Observations and Recommendations, '... provides greater opportunities'. Greater opportunities for what?

  2. The conclusion should reflect whether the aim of the report, set out in the list in the introduction, has been achieved.

Regards Denise

hansieodendaal commented 4 years ago

This looks good. I only have one question, please. In Table 3, No. 6, it is unclear what creates its own transcript.

Changed to: The verifier creates its own transcript.

hansieodendaal commented 4 years ago
  1. In the last sentence under Conclusions, Observations and Recommendations, '... provides greater opportunities'. Greater opportunities for what?

Sentence rewritten as This framework provides great opportunities in building blockchain-enabled confidential digital asset schemes.

  1. The conclusion should reflect whether the aim of the report, set out in the list in the introduction, has been achieved.

This sentence added: The use of ZK proofs for arithmetic circuits and programmable constraint systems has evolved considerably as illustrated in Table 2. The rest have been covered sufficiently.

hansieodendaal commented 4 years ago

Thank you @anselld, all questions resolved.