Closed sdbondi closed 1 month ago
544 tests +3 544 :white_check_mark: +3 3h 11m 22s :stopwatch: + 1h 24m 1s 64 suites +1 0 :zzz: ±0 2 files ±0 0 :x: ±0
Results for commit 72aa818c. ± Comparison against base commit ad490ae3.
:recycle: This comment has been updated with latest results.
Description
Improve API for resource builder with initial supply. Rename XTR2 constant to XTR Add
Bucket::join
Motivation and Context
Previously if you provided an initial supply for the resource builder and called
build()
a panic would occur. This PR changesinitial_supply
to immediately build and return the bucket preventing the user from making the above error at compile time.Previous API:
New API:
How Has This Been Tested?
Existing engine tests updated
What process can a PR reviewer use to test or verify this change?
Update existing templates to use the new API
Breaking Changes
BREAKING CHANGE: templates that previously built resources with initial supply will no longer compile. The ABI for buckets adds
Join
. Since the integer representation of the ops shifts by 1 afterJoin
some bucket operations will be invalid on previous WASM. i.e. WASM needs to be recompiled.