tari-project / tari-dan

BSD 3-Clause "New" or "Revised" License
5 stars 14 forks source link

refactor(indexer): event filtering and related substate storing #1043

Closed mrnaveira closed 1 month ago

mrnaveira commented 1 month ago

Description

Motivation and Context

Up until now, the behaviour of the indexer regarding events and substates was:

This PR refactors the indexer behaviour to be more useful:

Regarding the event filtering:

Regarding the substate storing:

This PR removes functionality regarding substate monitoring and address watchlist, as now the substate storing is determined by the events.

This PR keeps existing functionality regarding:

How Has This Been Tested?

Manually by:

What process can a PR reviewer use to test or verify this change?

See previous section.

Breaking Changes

github-actions[bot] commented 1 month ago

Test Results (CI)

535 tests   - 6   535 :white_check_mark:  - 6   1h 39m 38s :stopwatch: - 7m 43s  63 suites ±0     0 :zzz: ±0    2 files   ±0     0 :x: ±0 

Results for commit 0031ed88. ± Comparison against base commit ad490ae3.

This pull request removes 9 and adds 3 tests. Note that renamed tests count towards both. ``` Scenario: Indexer GraphQL filtering and pagination of events: tests/features/indexer.feature:157:3 Scenario: Indexer GraphQL requests events over network substate indexing: tests/features/indexer.feature:118:3 Scenario: Indexer GraphQL requests work: tests/features/indexer.feature:107:3 tari_indexer_client ‑ types::export_bindings_addaddressrequest tari_indexer_client ‑ types::export_bindings_addaddressresponse tari_indexer_client ‑ types::export_bindings_clearaddressesresponse tari_indexer_client ‑ types::export_bindings_deleteaddressrequest tari_indexer_client ‑ types::export_bindings_deleteaddressresponse tari_indexer_client ‑ types::export_bindings_getaddressesresponse ``` ``` Scenario: Indexer GraphQL filtering and pagination of events: tests/features/indexer.feature:147:3 Scenario: Indexer GraphQL requests events over network substate indexing: tests/features/indexer.feature:108:3 Scenario: Indexer GraphQL requests work: tests/features/indexer.feature:97:3 ```

:recycle: This comment has been updated with latest results.