search

tari-project / tari-dan

BSD 3-Clause "New" or "Revised" License
5 stars 14 forks source link

fix(rpc)!: remove chunking #1044

Closed sdbondi closed 1 month ago

sdbondi commented 1 month ago

Description

Motivation and Context

Chunking does not add any benefit especially when not using tor. Porting over changes from L1: https://github.com/tari-project/tari/pull/6345

How Has This Been Tested?

Manually

What process can a PR reviewer use to test or verify this change?

Should work as before

Breaking Changes

BREAKING CHANGE: Any responses which previously triggered chunking (>= 256kb) would not be readable by clients using this PR

github-actions[bot] commented 1 month ago

Test Results (CI)

536 tests   - 5   536 :white_check_mark:  - 5   1h 47m 51s :stopwatch: +30s  63 suites ±0     0 :zzz: ±0    2 files   ±0     0 :x: ±0 

Results for commit 107855b2. ± Comparison against base commit ad490ae3.

This pull request removes 5 tests. ``` tari_rpc_framework ‑ server::chunking::test::it_emits_a_single_message tari_rpc_framework ‑ server::chunking::test::it_emits_a_zero_size_message tari_rpc_framework ‑ server::chunking::test::it_emits_an_expected_number_of_chunks tari_rpc_framework ‑ server::chunking::test::it_emits_one_message_below_threshold tari_rpc_framework ‑ server::chunking::test::it_sets_the_more_flag_except_last ```