tari-project / tari-dan

BSD 3-Clause "New" or "Revised" License
5 stars 14 forks source link

fix(engine)!: allow multiple create components in one call #1046

Closed sdbondi closed 3 weeks ago

sdbondi commented 1 month ago

Description

Motivation and Context

Previously you could not create multiple components in one call without explicitly allocating an address. This PR changes the default behaviour to generate a unique address, thereby fixing the bug when creating multiple components in a single call. Some components need the address to be derived ahead of time using a public key can do this by optionally specifying a public key address on the component.

How Has This Been Tested?

New multiple component creation test. Existing account tests. Manually

What process can a PR reviewer use to test or verify this change?

Use a template that creates multiple components. Create an account that does not exist for another public key.

Breaking Changes

BREAKING CHANGE: caller context calls have an additional arg field, so templates using these need to be recompiled.

github-actions[bot] commented 1 month ago

Test Results (CI)

540 tests  +2   540 :white_check_mark: +2   1h 32m 24s :stopwatch: - 48m 32s  64 suites ±0     0 :zzz: ±0    2 files   ±0     0 :x: ±0 

Results for commit 83d55ad4. ± Comparison against base commit 0ebb1fb1.

:recycle: This comment has been updated with latest results.