tari-project / tari-dan

BSD 3-Clause "New" or "Revised" License
5 stars 14 forks source link

fix(consensus): various consensus fixes from tariswap testing #1062

Closed sdbondi closed 3 weeks ago

sdbondi commented 3 weeks ago

Description

fix(consensus): incorrect local_only flag on deferred execution fix(consensus): correct execution result for failures fix(consensus): use mempool execution if applicable when finalizing transactions fix(consensus): minor logging and error handling improvements fix: transaction generator and tariswap test chore: apply prettier rules to wallet daemon

Motivation and Context

Erroneous leader failures fixed:

Fixed tariswap tests. These now require multiple signers to authorize withdraws from accounts owned by different keys

How Has This Been Tested?

Running tariswap test

What process can a PR reviewer use to test or verify this change?

Run tariswap test

Breaking Changes

github-actions[bot] commented 3 weeks ago

Test Results (CI)

540 tests  ±0   540 :white_check_mark: ±0   1h 52m 12s :stopwatch: - 53m 14s  64 suites ±0     0 :zzz: ±0    2 files   ±0     0 :x: ±0 

Results for commit 3ae5c613. ± Comparison against base commit 058a0a72.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both. ``` Scenario: Claim validator fees: tests/features/claim_fees.feature:6:3 Scenario: Prevent double claim of validator fees: tests/features/claim_fees.feature:46:3 ``` ``` Scenario: Claim validator fees: tests/features/claim_fees.feature:7:3 Scenario: Prevent double claim of validator fees: tests/features/claim_fees.feature:47:3 ```

:recycle: This comment has been updated with latest results.