Closed mrnaveira closed 2 months ago
542 tests ±0 542 :white_check_mark: ±0 1h 30m 14s :stopwatch: - 16m 18s 64 suites ±0 0 :zzz: ±0 2 files ±0 0 :x: ±0
Results for commit e1a26698. ± Comparison against base commit f0beea46.
:recycle: This comment has been updated with latest results.
Description
Adds support for WalletConnect in the
tari_wallet_daemon_ui
:VITE_WALLET_CONNECT_PROJECT_ID
Motivation and Context
We want to support WalletConnect in Tari, as this is a de facto standard for web-to-wallet interaction. It will allow any wallet (web or mobile) to add support for Tari without us having to implement anything extra.
In this context, the goal of this PR is to add support for WalletConnect in the Tari Wallet Daemon alongside the exising TariConnector.
For now we have separated UI buttons for both TariConnector and WalletConnect, due do some TariConnect logic being entangled into the UI. It should be possible to refactor to only have one generic button that accepts both types of connection URIs but it was left out of the scope of this PR.
See https://github.com/tari-project/tari.js/pull/27 and https://github.com/tari-project/tari-template-web/pull/6 for more information.
How Has This Been Tested?
Manually by running
tari_swarm
, opening the tari wallet daemon web UI and then paste a valid WalletConnect URIWhat process can a PR reviewer use to test or verify this change?
See previous section
Breaking Changes