feat: consistent transaction abort reason - Githubissues

tari-project / tari-dan

BSD 3-Clause "New" or "Revised" License

7 stars 18 forks source link

feat: consistent transaction abort reason #1172

Closed ksrichard closed 1 month ago

ksrichard commented 1 month ago

Description

There was no exact reason when a transaction was aborted, so added all currently possible abort reasons.

Motivation and Context

There was no explicit reason/reason code provided for aborted transactions.

How Has This Been Tested?

Submitted a transaction with invalid versions of inputs:
Submitted 2 concurrent transactions which are causing one an abort error on locking inputs:

What process can a PR reviewer use to test or verify this change?

Breaking Changes

[ ] None
[ ] Requires data directory to be deleted
[x] Other - Please specify - Since a new data structure is used it can be inconsistent with older version of code, so a fresh start with deleted data/processes directory would be needed.

github-actions[bot] commented 1 month ago

Test Results (CI)

570 tests 569 :white_check_mark: 3h 18m 59s :stopwatch: 64 suites 0 :zzz: 2 files 1 :x:

For more details on these failures, see this check.

Results for commit 128ab0e8.

:recycle: This comment has been updated with latest results.