tari-project / tari-launchpad

A node, wallet and miner for Tari focusing on ease of use
BSD 3-Clause "New" or "Revised" License
8 stars 15 forks source link

fix: mining settings #168

Closed brianp closed 1 year ago

brianp commented 1 year ago

Description

There was a bug on the settings page which wouldn't allow some setting changes to be saved. The dirty tracking was working fine but the Save would not enable. This was because by default there is no value for the monero address but the monero address was marked as a required field. Meaning until one was entered no other changes were considered valid for saving.

I fixed this by removing the requirement of having the monero address.

Additionally I separated the SHA3 mining cores number from the rest of the monero mining settings. New layout:

image

Motivation and Context

The settings page felt broken as you would make changes but still couldn't save or apply your changes seemingly without reason.

Fixes: #159 Fixes: #161

How Has This Been Tested?

Manually