Comms- Ban bad messages

tari-project / tari

The Tari protocol

https://tari.com

BSD 3-Clause "New" or "Revised" License

347 stars 215 forks source link

Comms- Ban bad messages #5541

Open SWvheerden opened 1 year ago

SWvheerden commented 1 year ago

Currently, not all bad behaviour is punished in the comms layer:

[x] SAF/Store: the message has no signature
[x] SAF_handler/task: invalid saf message
[ ] SAF_handler/task: peer send saf message we did not request
[x] inbound/forward: destination matches source
[ ] DHT header params

sdbondi commented 1 year ago

Updating here with the fixes from https://github.com/tari-project/tari/pull/5711

~~SAF/Store: the message has no signature~~ Fixed: banned in the decrypt middleware
~~SAF_handler/task: invalid saf message~~ Fixed
SAF_handler/task: peer send saf message we did not request
~~inbound/forward: destination matches source~~ Fixed

SWvheerden commented 1 year ago

Some DHT message types have specific parameters in the DHT header that must be satified. For example, 
a Discovery response should be sent directly, signed and not encypted. We should enforce (validate and ban) 
these rules per message type to reduce attack surface