search

tari-project / tari

The Tari protocol
https://tari.com
BSD 3-Clause "New" or "Revised" License
345 stars 212 forks source link

fix!: change position calculation in MTparams for mergemining #6339

Closed SWvheerden closed 3 months ago

SWvheerden commented 3 months ago

Description

Changes the way we calculate the position of the hash from the Merkle tree params

Motivation and Context

Its possible to have the same proof for different sized merkle trees. Verification needs to verify the total size from the decoded merkle tree params

What process can a PR reviewer use to test or verify this change?

Ensure it's the same as here: https://github.com/SChernykh/p2pool/blob/2c549f61a46a5f4f0be7c631dff6e928f73a52e2/src/merkle.cpp#L341-L369

github-actions[bot] commented 3 months ago

Test Results (CI)

    3 files    120 suites   40m 3s :stopwatch: 1 280 tests 1 279 :white_check_mark: 0 :zzz: 1 :x: 3 832 runs  3 831 :white_check_mark: 0 :zzz: 1 :x:

For more details on these failures, see this check.

Results for commit b4bfaa83.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 3 months ago

Test Results (Integration tests)

 2 files  11 suites   40m 24s :stopwatch: 33 tests 32 :white_check_mark: 0 :zzz: 1 :x: 35 runs  32 :white_check_mark: 0 :zzz: 3 :x:

For more details on these failures, see this check.

Results for commit b4bfaa83.

:recycle: This comment has been updated with latest results.