tari-project / tari

The Tari protocol
https://tari.com
BSD 3-Clause "New" or "Revised" License
339 stars 210 forks source link

feat!: export unblinded outputs #6361

Closed hansieodendaal closed 1 month ago

hansieodendaal commented 1 month ago

Description

Exported unblinded UTXOs. In a previous PR the ability to export unblinded UTXOs were removed; this PR reinstates that ability. Also updated the wallet FFI to include all related methods.

Motivation and Context

See above.

How Has This Been Tested?

System-level testing Updated the wallet FFI unit test (test_import_external_utxo)

What process can a PR reviewer use to test or verify this change?

Export utxos

Breaking Changes

BREAKING CHANGE: Wallet FFI interface change to import UTXOs.

github-actions[bot] commented 1 month ago

Test Results (CI)

    3 files    120 suites   38m 7s :stopwatch: 1 295 tests 1 295 :white_check_mark: 0 :zzz: 0 :x: 3 877 runs  3 877 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 6287e0b1.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 month ago

Test Results (Integration tests)

 2 files  + 2   1 errors  9 suites  +9   26m 21s :stopwatch: + 26m 21s 19 tests +19  14 :white_check_mark: +14  0 :zzz: ±0   5 :x: + 5  28 runs  +28  15 :white_check_mark: +15  0 :zzz: ±0  13 :x: +13 

For more details on these parsing errors and failures, see this check.

Results for commit 6287e0b1. ± Comparison against base commit 97b51286.

:recycle: This comment has been updated with latest results.

hansieodendaal commented 1 month ago

Yeah, I thought about adding RangeProof to UnblindedOutput, and maybe it is better that way. Will change.