tari-project / tari

The Tari protocol
https://tari.com
BSD 3-Clause "New" or "Revised" License
339 stars 210 forks source link

feat: remove ablity to send 1-sided tx #6367

Closed SWvheerden closed 1 month ago

SWvheerden commented 1 month ago

Description

Removes the ability to send one-sided transactions from the CW, preferring to only send stealth one-sided

Motivation and Context

There is no benefit for sending normal one-sided, only negatives in regard to privacy

github-actions[bot] commented 1 month ago

Test Results (CI)

    3 files    120 suites   44m 37s :stopwatch: 1 295 tests 1 295 :white_check_mark: 0 :zzz: 0 :x: 3 877 runs  3 877 :white_check_mark: 0 :zzz: 0 :x:

Results for commit e22dfca8.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 month ago

Test Results (Integration tests)

 2 files  + 2   1 errors  9 suites  +9   12m 8s :stopwatch: + 12m 8s 19 tests +19  15 :white_check_mark: +15  0 :zzz: ±0   4 :x: + 4  27 runs  +27  15 :white_check_mark: +15  0 :zzz: ±0  12 :x: +12 

For more details on these parsing errors and failures, see this check.

Results for commit e22dfca8. ± Comparison against base commit 97b51286.

:recycle: This comment has been updated with latest results.

SWvheerden commented 1 month ago

I want to keep that in for now, until we know exactly how we want to work with exchanges, they want want to use it. So for now I am only removing the front end calling