search

tari-project / tari

The Tari protocol
https://tari.com
BSD 3-Clause "New" or "Revised" License
339 stars 210 forks source link

feat!: change tar address to use base58 and not hex #6372

Closed SWvheerden closed 1 month ago

SWvheerden commented 1 month ago

Description

Remove hex display from tari address Use Base 58 encoding instead. Keeps the network and features human readable

Motivation and Context

reduces the display size from 134 chars, down to 92

How Has This Been Tested?

unit tests and manual

github-actions[bot] commented 1 month ago

Test Results (CI)

    3 files    120 suites   45m 16s :stopwatch: 1 295 tests 1 295 :white_check_mark: 0 :zzz: 0 :x: 3 877 runs  3 877 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 3538e6fa.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 month ago

Test Results (Integration tests)

 2 files  11 suites   33m 15s :stopwatch: 35 tests 34 :white_check_mark: 0 :zzz: 1 :x: 37 runs  35 :white_check_mark: 0 :zzz: 2 :x:

For more details on these failures, see this check.

Results for commit 3538e6fa.

:recycle: This comment has been updated with latest results.

hansieodendaal commented 1 month ago

Some clippy and compile issues?

hansieodendaal commented 1 month ago

Some cucumber tests are still failing