search

tari-project / tari

The Tari protocol
https://tari.com
BSD 3-Clause "New" or "Revised" License
339 stars 210 forks source link

fix: keep alpha key constant #6375

Closed SWvheerden closed 1 month ago

SWvheerden commented 1 month ago

Description

FFI now re-uses alpha from previous runs. Move DB read of the alpha key from console wallet to wallet lib

Motivation and Context

The alpha key should be constant across starts, the FFI creates a new alpha key on each startup

github-actions[bot] commented 1 month ago

Test Results (CI)

    3 files    120 suites   35m 48s :stopwatch: 1 295 tests 1 295 :white_check_mark: 0 :zzz: 0 :x: 3 877 runs  3 877 :white_check_mark: 0 :zzz: 0 :x:

Results for commit b18ef63f.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 month ago

Test Results (Integration tests)

 2 files  11 suites   42m 0s :stopwatch: 35 tests 33 :white_check_mark: 0 :zzz: 2 :x: 39 runs  34 :white_check_mark: 0 :zzz: 5 :x:

For more details on these failures, see this check.

Results for commit b18ef63f.

:recycle: This comment has been updated with latest results.

hansieodendaal commented 1 month ago

Some failing cucumber integration tests

SWvheerden commented 1 month ago

The name and description of the PR do not line up with the code changes. I think a better explanation is needed.

The description is correct. Alpha is now always loaded in and not just from CW side.