fix: claim n of m faucet

tari-project / tari

The Tari protocol

https://tari.com

BSD 3-Clause "New" or "Revised" License

347 stars 215 forks source link

fix: claim n of m faucet #6389

Closed SWvheerden closed 2 months ago

SWvheerden commented 3 months ago

Description

Fixes n-of-m spending of faucets.

Motivation and Context

Allows spending of m-of-n

How Has This Been Tested?

Manual

github-actions[bot] commented 3 months ago

Test Results (CI)

3 files 120 suites 37m 22s :stopwatch: 1 295 tests 1 295 :white_check_mark: 0 :zzz: 0 :x: 3 877 runs 3 877 :white_check_mark: 0 :zzz: 0 :x:

Results for commit a7a2b3a9.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 3 months ago

Test Results (Integration tests)

2 files + 2 11 suites +11 15m 13s :stopwatch: + 15m 13s 35 tests +35 34 :white_check_mark: +34 0 :zzz: ±0 1 :x: +1 36 runs +36 35 :white_check_mark: +35 0 :zzz: ±0 1 :x: +1

For more details on these failures, see this check.

Results for commit a7a2b3a9. ± Comparison against base commit 0156fc54.

:recycle: This comment has been updated with latest results.

hansieodendaal commented 2 months ago

I found another issue. The encumbered transaction (FaucetEncumberAggregateUtxo) is broadcast if the wallet is opened before it is finalized with FaucetSpendAggregateUtxo.

SWvheerden commented 2 months ago

Yeah lets keep that as a known issue, and you should use --command-mode-auto-exit for now