tari-project / tari

The Tari protocol
https://tari.com
BSD 3-Clause "New" or "Revised" License
350 stars 218 forks source link

fix: panic in from_base58 fn #6414

Closed SWvheerden closed 3 months ago

SWvheerden commented 3 months ago

Description

Fixes potential panic in: from_base58 function Removes uses of split_at and replaces with checked version where user strings are used as input

Motivation and Context

Code should not panic

github-actions[bot] commented 3 months ago

Test Results (CI)

    3 files    120 suites   43m 55s :stopwatch: 1 295 tests 1 295 :white_check_mark: 0 :zzz: 0 :x: 3 877 runs  3 877 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 72b96aca.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 3 months ago

Test Results (Integration tests)

 2 files  11 suites   35m 20s :stopwatch: 35 tests 33 :white_check_mark: 0 :zzz: 2 :x: 39 runs  34 :white_check_mark: 0 :zzz: 5 :x:

For more details on these failures, see this check.

Results for commit 72b96aca.

:recycle: This comment has been updated with latest results.