search

tari-project / tari

The Tari protocol
https://tari.com
BSD 3-Clause "New" or "Revised" License
350 stars 218 forks source link

feat: add network wire byte #6518

Closed hansieodendaal closed 2 months ago

hansieodendaal commented 2 months ago

Description

Added network wire byte. This is now independent of the network as byte.

Note: This method in favour of #6502.

Motivation and Context

Base nodes and wallets maintained numerous connections from which they could not sync or obtain useful information. This caused base nodes to try and follow other base nodes that were on a higher proof of work but on a different genesis block, and caused wallets to query base nodes that supplied information from a different blockchain. This byte can now be changed every time the genesis block changes.

How Has This Been Tested?

Passed all unit tests.

What process can a PR reviewer use to test or verify this change?

Breaking Changes

github-actions[bot] commented 2 months ago

Test Results (CI)

    3 files    129 suites   38m 44s :stopwatch: 1 308 tests 1 308 :white_check_mark: 0 :zzz: 0 :x: 3 910 runs  3 910 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 24b40558.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 months ago

Test Results (Integration tests)

 2 files  11 suites   29m 51s :stopwatch: 36 tests 35 :white_check_mark: 0 :zzz: 1 :x: 37 runs  36 :white_check_mark: 0 :zzz: 1 :x:

For more details on these failures, see this check.

Results for commit 24b40558.

:recycle: This comment has been updated with latest results.