Closed CjS77 closed 1 month ago
3 files 129 suites 36m 17s :stopwatch: 1 325 tests 1 325 :white_check_mark: 0 :zzz: 0 :x: 3 973 runs 3 973 :white_check_mark: 0 :zzz: 0 :x:
Results for commit f5a5de6e.
:recycle: This comment has been updated with latest results.
2 files 11 suites 15m 40s :stopwatch: 36 tests 35 :white_check_mark: 0 :zzz: 1 :x: 37 runs 36 :white_check_mark: 0 :zzz: 1 :x:
For more details on these failures, see this check.
Results for commit f5a5de6e.
:recycle: This comment has been updated with latest results.
Description
Update
PaymentId
Display
implementationMotivation and Context
The main current use case for
PaymentId::to_string()
, besides logging, is passing the payment ID to the notification script.The current implentation makes it awkward to deal with:
This update addresses these issues, while still maintaining clear readibility in logs:
N/A
to None and eliminate any edge cases that may creep in when dealing with a slash<type>(<data>,...)
e.g.u64(1235678)
oraddress_and_data(f3S7XTiyKQauZpDUjdR8NbcQ33MYJigiWiS44ccZCxwAAjk,48656c6c6f20576f726c64)
How Has This Been Tested?
A single test for displaying each
PaymentId
type is also included.Breaking Changes