tari-project / tari

The Tari protocol
https://tari.com
BSD 3-Clause "New" or "Revised" License
356 stars 220 forks source link

feat: update payment_id display #6597

Closed CjS77 closed 1 month ago

CjS77 commented 1 month ago

Description

Update PaymentId Display implementation

Motivation and Context

The main current use case for PaymentId::to_string(), besides logging, is passing the payment ID to the notification script.

The current implentation makes it awkward to deal with:

This update addresses these issues, while still maintaining clear readibility in logs:

How Has This Been Tested?

A single test for displaying each PaymentId type is also included.

Breaking Changes

github-actions[bot] commented 1 month ago

Test Results (CI)

    3 files    129 suites   36m 17s :stopwatch: 1 325 tests 1 325 :white_check_mark: 0 :zzz: 0 :x: 3 973 runs  3 973 :white_check_mark: 0 :zzz: 0 :x:

Results for commit f5a5de6e.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 month ago

Test Results (Integration tests)

 2 files  11 suites   15m 40s :stopwatch: 36 tests 35 :white_check_mark: 0 :zzz: 1 :x: 37 runs  36 :white_check_mark: 0 :zzz: 1 :x:

For more details on these failures, see this check.

Results for commit f5a5de6e.

:recycle: This comment has been updated with latest results.