tari-project / tari

The Tari protocol
https://tari.com
BSD 3-Clause "New" or "Revised" License
356 stars 220 forks source link

feat!: add dns resiliency #6629

Closed hansieodendaal closed 1 month ago

hansieodendaal commented 1 month ago

Description

Added DNS resiliency to the DNS resolver. The config setting now accepts a list of DNS servers, including system, and will try them one after the other in case of failure to connect.

Motivation and Context

The DNS connection using system did not work on iPhone.

How Has This Been Tested?

System-level testing.

What process can a PR reviewer use to test or verify this change?

Code review.

Breaking Changes

BREAKING CHANGE: Wallet FFI method wallet_create has one additional parameter, which can be set as null ptr.

github-actions[bot] commented 1 month ago

Test Results (CI)

    3 files    129 suites   39m 23s :stopwatch: 1 337 tests 1 337 :white_check_mark: 0 :zzz: 0 :x: 4 009 runs  4 009 :white_check_mark: 0 :zzz: 0 :x:

Results for commit a3bf2719.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 month ago

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   33m 48s :stopwatch: + 33m 48s 36 tests +36  35 :white_check_mark: +35  0 :zzz: ±0  1 :x: +1  38 runs  +38  36 :white_check_mark: +36  0 :zzz: ±0  2 :x: +2 

For more details on these failures, see this check.

Results for commit a3bf2719. ± Comparison against base commit 2d0ccb12.

:recycle: This comment has been updated with latest results.