search

tari-project / tari

The Tari protocol
https://tari.com
BSD 3-Clause "New" or "Revised" License
356 stars 220 forks source link

refactor: libp2p #6630

Closed sdbondi closed 4 weeks ago

sdbondi commented 1 month ago

Description

Motivation and Context

How Has This Been Tested?

What process can a PR reviewer use to test or verify this change?

Breaking Changes

github-actions[bot] commented 1 month ago

Test Results (CI)

    3 files    126 suites   11m 45s ⏱️ 1 160 tests 1 160 ✅ 0 💤 0 ❌ 3 480 runs  3 480 ✅ 0 💤 0 ❌

Results for commit 60e0fb5d.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 month ago

Test Results (Integration tests)

 2 files  + 2  10 suites  +10   3h 8m 43s ⏱️ + 3h 8m 43s 23 tests +23  14 ✅ +14  0 💤 ±0   9 ❌ + 9  41 runs  +41  14 ✅ +14  0 💤 ±0  27 ❌ +27 

For more details on these failures, see this check.

Results for commit 659172dd. ± Comparison against base commit 47b48770.

:recycle: This comment has been updated with latest results.

hansieodendaal commented 1 month ago

Hi Stan,

Will get to this tomorrow morning.

Regards, Hansie.

On Fri, 18 Oct 2024 at 11:21, Stan Bondi @.***> wrote:

@sdbondi https://github.com/sdbondi requested review from @tari-project/tari-core-developers on: #6630 https://github.com/tari-project/tari/pull/6630 refactor: libp2p as a code owner.

— Reply to this email directly, view it on GitHub https://github.com/tari-project/tari/pull/6630#event-14715960524, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJKVKZTXZSHHBVWIIBEX3M3Z4DHKDAVCNFSM6AAAAABP63AH7GVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUG4YTKOJWGA2TENA . You are receiving this because your review was requested.Message ID: @.***>

--

Hansie Odendaal Senior Rust Developer, Protocol Tari Labs (Pty) Ltd

sdbondi commented 4 weeks ago

@SWvheerden Thank you for the review! I've implemented some of the requested features. The message metrics are a little tougher, there are many ways to do it but I'd like to use libp2p metrics (to get libp2p metrics in general in addition to messaging metrics) but I'd need to upgrade metrics code since libp2p uses the prometheus-client 0.22 registry and we use an older version of prometheus.