search

tari-project / tari

The Tari protocol
https://tari.com
BSD 3-Clause "New" or "Revised" License
356 stars 220 forks source link

feat: change ffi wallet recovery interface #6636

Closed hansieodendaal closed 1 month ago

hansieodendaal commented 1 month ago

Description

Changed the FFI wallet recovery interface to accept a list of base node peers for recovery instead of only a single peer. This will enable the mobile wallet to pass all seed peers to the recovery process instead of only a single peer.

Motivation and Context

The recovery process for the mobile wallet should work in the same way that the console wallet does.

How Has This Been Tested?

Must be tested with system-level tests with the mobile wallet.

What process can a PR reviewer use to test or verify this change?

Code review.

Breaking Changes

BREAKING CHANGE: Wallet FFI method pub unsafe extern "C" fn wallet_start_recovery( had an interface update.

github-actions[bot] commented 1 month ago

Test Results (CI)

    3 files    129 suites   35m 41s :stopwatch: 1 337 tests 1 337 :white_check_mark: 0 :zzz: 0 :x: 4 009 runs  4 009 :white_check_mark: 0 :zzz: 0 :x:

Results for commit e270ef66.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 month ago

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   38m 11s :stopwatch: + 38m 11s 36 tests +36  34 :white_check_mark: +34  0 :zzz: ±0  2 :x: +2  38 runs  +38  36 :white_check_mark: +36  0 :zzz: ±0  2 :x: +2 

For more details on these failures, see this check.

Results for commit e270ef66. ± Comparison against base commit 1319e247.

:recycle: This comment has been updated with latest results.