search

tari-project / tari

The Tari protocol
https://tari.com
BSD 3-Clause "New" or "Revised" License
356 stars 220 forks source link

GRPC request for wallet address seems wrong? #6641

Open leet4tari opened 1 month ago

leet4tari commented 1 month ago

Using a grpc command line client for testing, doing a request for the wallet address returns the following

{
 "interactive_address": "AgMul6+IgTQZ46vxd6jjYns8zp9+3vukUaaepU6qF8MLMoZt3gjutTS78qgnmXFd/EClOMSh1JqJk5X6l6aVx8ZDBA==",
 "one_sided_address": "AgEul6+IgTQZ46vxd6jjYns8zp9+3vukUaaepU6qF8MLMoZt3gjutTS78qgnmXFd/EClOMSh1JqJk5X6l6aVx8ZDKw=="
}

where the wallet address should be

Tari Address interactive:   3457UQxqpvSJnSyGFkgHkJgJB6r7BM3L4MM5nLL6jZpok3Pk8mtCnHGQi2HeRjHcUS7BwEPGcoRvBB43Y2einGhX8Mq                                            
Tari Address one-sided:     3257UQxqpvSJnSyGFkgHkJgJB6r7BM3L4MM5nLL6jZpok3Pk8mtCnHGQi2HeRjHcUS7BwEPGcoRvBB43Y2einGhX8NW

Tried base64 and base58 decoding, neither decoders return a similar address.

Could I get some info on how to get this to work or get what I am looking for?

SWvheerden commented 1 month ago

What you are showing here is not possible, the client you are using is somehow encoding the results. https://github.com/tari-project/tari/blob/c42586517a06382106a7fb20939e0a9cbe2e5789/applications/minotari_app_grpc/proto/wallet.proto#L91C1-L92C1

those should be bytes, not a string.

SWvheerden commented 1 month ago

But it might be worth the effort to make this a string and encode it to base58. Is going to be a breaking change

leet4tari commented 1 month ago

How about getAddressString which would not break the current interface?