fix(comms): ensure that inbound messaging terminates on disconnect

sdbondi commented 3 weeks ago

Description

Motivation and Context

Ensure that the inbound messaging worker terminates when the peer connection is disconnected. This PR ensures this by using the PeerConnection::on_disconnect future. It has not been confirmed that the inbound worker would not terminate before however this PR will guarantee it.

How Has This Been Tested?

Updated unit tests.

What process can a PR reviewer use to test or verify this change?

Breaking Changes

[x] None
[ ] Requires data directory on base node to be deleted
[ ] Requires hard fork
[ ] Other - Please specify

github-actions[bot] commented 3 weeks ago

Test Results (CI)

3 files 129 suites 39m 28s ⏱️ 1 344 tests 1 344 ✅ 0 💤 0 ❌ 4 030 runs 4 030 ✅ 0 💤 0 ❌

Results for commit 6629a261.

github-actions[bot] commented 3 weeks ago

Test Results (Integration tests)

2 files + 2 11 suites +11 23m 25s ⏱️ + 23m 25s 36 tests +36 35 ✅ +35 0 💤 ±0 1 ❌ +1 37 runs +37 36 ✅ +36 0 💤 ±0 1 ❌ +1

For more details on these failures, see this check.

Results for commit 6629a261. ± Comparison against base commit f8027435.

hansieodendaal commented 3 weeks ago

Nice one

tari-project / tari