fix!: explictly close rpc connections when changing base node

tari-project / tari

The Tari protocol

https://tari.com

BSD 3-Clause "New" or "Revised" License

354 stars 219 forks source link

fix!: explictly close rpc connections when changing base node #6662

Closed sdbondi closed 2 weeks ago

sdbondi commented 3 weeks ago

Description

fix!: explictly close rpc connections when changing base node establish relay quickly fix wallet connectivity logic

Motivation and Context

How Has This Been Tested?

What process can a PR reviewer use to test or verify this change?

Breaking Changes

[ ] None
[ ] Requires data directory on base node to be deleted
[ ] Requires hard fork
[x] Other - Please specify

BREAKING CHANGE: RPC protocol adds the "check bytes" periodically sent by the server. These bytes will cause errors in older clients.

github-actions[bot] commented 3 weeks ago

Test Results (Integration tests)

2 files 1 errors 9 suites 1h 34m 39s ⏱️ 18 tests 14 ✅ 0 💤 4 ❌ 26 runs 14 ✅ 0 💤 12 ❌

For more details on these parsing errors and failures, see this check.

Results for commit e96337b9.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 3 weeks ago

Test Results (CI)

3 files 126 suites 9m 47s ⏱️ 1 160 tests 1 160 ✅ 0 💤 0 ❌ 3 480 runs 3 480 ✅ 0 💤 0 ❌

Results for commit e96337b9.

:recycle: This comment has been updated with latest results.

hansieodendaal commented 2 weeks ago

I conducted many system-level stress tests with this branch and feel that the libp2p implementation is pretty solid for almost all use cases, and am happy to approve this PR. Outstanding issues are logged in https://github.com/orgs/tari-project/projects/25/views/1.