Closed hansieodendaal closed 1 week ago
3 files 126 suites 9m 26s ⏱️ 1 161 tests 1 161 ✅ 0 💤 0 ❌ 3 483 runs 3 483 ✅ 0 💤 0 ❌
Results for commit d94ea102.
:recycle: This comment has been updated with latest results.
2 files 10 suites 15m 53s ⏱️ 23 tests 22 ✅ 0 💤 1 ❌ 25 runs 23 ✅ 0 💤 2 ❌
For more details on these failures, see this check.
Results for commit d94ea102.
:recycle: This comment has been updated with latest results.
Description
FIx cucumber tests on libp2p feature branch
Notes:
--concurrency 1
were detected locally, more so for the wallet FFI suite of tests than the normal tests, but--concurrency 1
is recommended for both. This is because addresses are mixed (discoverable) with libp2p when running in the single cucumber process.Motivation and Context
Some tests were failing
How Has This Been Tested?
cargo test --release --test cucumber -- --tags "@wallet-ffi and not @broken" --concurrency 1 --retry 2
cargo test --release --all-features --test cucumber -- --tags "@critical and (not @long-running) and (not @wallet-ffi) and (not @chat-ffi) and (not @broken)" --concurrency 1 --retry 2
What process can a PR reviewer use to test or verify this change?
Code review Run the cucumber tests
Breaking Changes
BREAKING CHANGE: Wallet FFI interface change on
pub unsafe extern "C" fn comms_config_create