tari-project / tari

The Tari protocol
https://tari.com
BSD 3-Clause "New" or "Revised" License
356 stars 220 forks source link

feat: fix base node shutdown #6697

Closed hansieodendaal closed 5 days ago

hansieodendaal commented 6 days ago

Description

Fixed the base node shutdown on Ubuntu (and hopefully on MacOS) whereas pressing Ctrl-C multiple times rendered the command line interface in an undefined state. This was not issue on Windows.

Note: The change to 'base_layer\core\src\base_node\tari_pulse_service\mod.rs' is an interim change to enable testing (getting rid of the repeated command-line spam) but not required for the base node to shut down. More changes in #6696.

Motivation and Context

The base node did not shut down properly on Ubuntu and MacOs.

How Has This Been Tested?

System-level testing on Windows and Ubuntu (WSL).

What process can a PR reviewer use to test or verify this change?

System-level testing - still outstanding on MacOS

Breaking Changes

github-actions[bot] commented 6 days ago

Test Results (CI)

    3 files    129 suites   39m 22s ⏱️ 1 344 tests 1 344 ✅ 0 💤 0 ❌ 4 030 runs  4 030 ✅ 0 💤 0 ❌

Results for commit fbf6099e.

github-actions[bot] commented 6 days ago

Test Results (Integration tests)

36 tests  +36   36 ✅ +36   14m 38s ⏱️ + 14m 38s 11 suites +11    0 💤 ± 0   2 files   + 2    0 ❌ ± 0 

Results for commit fbf6099e. ± Comparison against base commit 0610bcce.