search

tari-project / universe

Other
8 stars 24 forks source link

Minotari node requires VS redist #132

Open ghost opened 2 months ago

ghost commented 2 months ago

Describe the bug After using the workaround to the bug here: https://github.com/tari-project/universe/issues/131 , I got the Tari Universe app to install but running it was blocked by an error. It was never able to start.

To Reproduce Steps to reproduce the behavior: See the workaround for issue https://github.com/tari-project/universe/issues/131 . I had to use the workaround to get to the point where Tari Universe was installed and trying to Complete is own download prior to mining.

I got this error after the app opened and tried to start its initialization: Screenshot 2024-08-23 at 5 22 40 PM

Desktop (please complete the following information):

leet4tari commented 2 months ago

@Cultmojo if you download and install the Microsoft Visual C++ Redistributable from https://aka.ms/vs/17/release/vc_redist.x64.exe and restart the app, does it solve the problem?

ghost commented 2 months ago

@leet4tari That does solve the install issue.

leet4tari commented 2 months ago

After trying to bundle the Microsoft Visual C++ Redistributable and running into a number of install problems, I think it might be easier and possible better, to do an register check if the VC redistributable is installed, and if not, open a dialog/popup that will have the link to download and install, instead of failing.

Key="SOFTWARE\Microsoft\VisualStudio\14.0\VC\Runtimes\X64"
Name="Installed"
Value="1"
Screenshot 2024-08-29 at 10 57 28 Screenshot 2024-08-29 at 10 58 40
uforiaio commented 1 month ago

If the installer can query wmic to see if vc++ redist is installed or not, it would make it easier to validate the dependencies. If the vc++ versions are added to experimental "versions" it may be helpful. If it is not detected, have an info dialogue to download them via a link within Tari.

image

wmic product where "Name like '%%Visual C++%%'" get Name, Version

Microsoft Visual C++ 2022 X86 Minimum Runtime - 14.40.33810 14.40.33810 Microsoft Visual C++ 2022 X86 Additional Runtime - 14.40.33810 14.40.33810 Microsoft Visual C++ 2022 X64 Minimum Runtime - 14.40.33810 14.40.33810 Microsoft Visual C++ 2022 X64 Additional Runtime - 14.40.33810 14.40.33810

leet4tari commented 3 weeks ago

Some corner cases covered #750 , still a little bit of work to complete.