tari-project / universe

Other
8 stars 24 forks source link

[0.2.5 Windows] Ludicrous mode does not honour XMRig's optimized settings #333

Open hansieodendaal opened 1 month ago

hansieodendaal commented 1 month ago

Describe the bug When starting XMRig with --threads=-1 command line option or

    "cpu": {
        "enabled": true,
        "rx": {
            "intensity": 1,
            "threads": -1,
            "affinity": -1
        }
    },

in the config.json file, XMRig will automatically assign threads equal to the amount of physical cores, not the number of logical processors/threads. Currently when selecting Ludicrous mode all available logical processors/threads are assigned. This actually runs a lot slower than the XMRig optimized setting (threads equal to the amount of physical cores) and consumes all processing resources on the computer.

image

To Reproduce Steps to reproduce the behavior:

  1. Start mining with Ludicrous mode
  2. Notice the number of threads in C:\Users\<USER>\AppData\Roaming\com.tari.universe\logs\xmrig.log

Expected behavior Ludicrous mode should assign threads equal to the amount of physical cores.

Desktop (please complete the following information):

stringhandler commented 1 month ago

Thanks for your insight on this. So are you saying we should pass --threads=-1 or are you suggesting somethign else?

stringhandler commented 1 month ago

Suggested resolution: Eco mode should be 30% of physical cores. Ludicrous mode should just use --threads=-1

stringhandler commented 1 month ago

I suggest we add fields in the settings for Eco mode threads and Ludicrous mode threads, with defaults physical cores * 0.3 and -1 respectively.

I also think we should allow a user to specify the config file in settings, Xmrig config file override, which if it is populated, is used and only the mmproxy port and monero address are passed to xmrig when starting.