tari-project / universe

Other
8 stars 25 forks source link

0.5.18: Language translations: Text still appearing in English when user changes to a different language preference #785

Open Tas4tari opened 1 week ago

Tas4tari commented 1 week ago

Describe the bug

To Reproduce Steps to reproduce the behavior:

  1. Install and open the miner
  2. Ensure you are connected to Airdrop
  3. Click on the Settings icon
  4. Within General click on the language drop down
  5. Select any language other than English
  6. Go to the Airdrop settings window
  7. View the Airdrop settings
  8. Close Settings
  9. On the miner widget, click on the ? icon within the Est tXTM/day section
  10. View the pop up text

Expected behavior I should see the text displayed as the language preference I have set and not in English

Screenshots

Screenshot 2024-10-09 at 11 08 53 Screenshot 2024-10-09 at 11 35 18

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

Tas4tari commented 1 week ago

Also prevalent on Build 0.5.20, NextNet

Tas4tari commented 1 week ago

Prevalent on 0.5.22: With Deutsch, the TestNet rewards pop up text is still in English as well as the Claim gems pop up text Experimental settings: For all language translations, the GPU Mining devices section is still in English Screenshot (98) Screenshot (97) Screenshot (96)

Screenshot (95)

Screenshot (103)

Anziskavds commented 6 days ago

This is also on MacBook Air 13 inch M1 2020 on Sonoma 14.5 on Testnet 0.5.22.

Tas4tari commented 6 days ago

Tested on Releasee version 0.5.24: Windows 11 Translations do not carry across the site, for Deutsch, the earn gems and maake Tari Universe better text and sub text is still in English as well. All the other translations mentioned in the above comments and description are still prevalent on v0.5.24: Screenshot (115) (1)

Tas4tari commented 5 days ago

Tested on Windows 11 on NextNet version 0.5.27. Issue still persists

Tas4tari commented 5 days ago

Tested on v 0.5.28 and this is still prevalent. Across all languaages, new settings text still appears in english for all languages: Screenshot (142) Screenshot (141) Screenshot (140) Screenshot (139)

mmrrnn commented 1 hour ago

The problem is that all new texts are filled in English, to be replaced later by the target translation.

The only thing I can do is to add all the hardcoded texts to i18n so that they can be translated later from English

mmrrnn commented 1 hour ago

I'll also add Lint rule for inline texts that aren't wrapped in i18n