tari-project / universe

Other
11 stars 24 forks source link

Wallet connect: Restore from seed phrase: When I restore my miner wallet on Aurora, I noticed that the addresses differ #795

Open Tas4tari opened 1 month ago

Tas4tari commented 1 month ago

Describe the bug As an Android user when I restore my wallet vis seed phrase on Aurora on Android, I find that my wallet emoji address on Aurora differs slightly from the wallet emoji address displayed on tari universe: Miner address: ๐ŸŒˆ๐Ÿ“Ÿ๐Ÿ“ก๐Ÿš‘๐Ÿฆ†๐ŸŽบ๐Ÿšฆ๐Ÿฏ๐Ÿ•๐Ÿ‘๐ŸŽฑ๐Ÿšš๐ŸŽ“๐Ÿ‘‘๐Ÿ‘—๐Ÿค–๐Ÿ’๐Ÿšฒ๐ŸŒด๐Ÿญ๐Ÿ””๐Ÿ‘—๐Ÿ„๐Ÿจ๐ŸŽ‰๐Ÿค”๐Ÿ’ก๐Ÿ‘–๐Ÿฏ๐ŸŽค๐Ÿ‘€๐Ÿšฟ๐Ÿฆ๐Ÿ‹๐Ÿ’‰๐Ÿค–๐Ÿ‘ถ๐Ÿ๐Ÿ‘Ÿ๐Ÿ‘๐Ÿ”’๐Ÿ‘‚๐Ÿ”ฑ๐Ÿฅ‘๐ŸŒ๐Ÿงข๐ŸŸ๐Ÿ‘—๐ŸŽ๐Ÿ“–๐Ÿ‘๐ŸŠ๐Ÿซ๐ŸŒ•๐Ÿšฒ๐Ÿ๐Ÿ๐Ÿ“ก๐Ÿ๐Ÿ๐Ÿต๐Ÿšจ๐Ÿœ๐Ÿ‘ ๐ŸŽ๐Ÿฅ๐ŸŽฎ Aurora: ๐ŸŒˆ๐ŸŒŠ๐Ÿ“ก๐Ÿš‘๐Ÿฆ†๐ŸŽบ๐Ÿšฆ๐Ÿฏ๐Ÿ•๐Ÿ‘๐ŸŽฑ๐Ÿšš๐ŸŽ“๐Ÿ‘‘๐Ÿ‘—๐Ÿค–๐Ÿ’๐Ÿšฒ๐ŸŒด๐Ÿญ๐Ÿ””๐Ÿ‘—๐Ÿ„๐Ÿจ๐ŸŽ‰๐Ÿค”๐Ÿ’ก๐Ÿ‘–๐Ÿฏ๐ŸŽค๐Ÿ‘€๐Ÿšฟ๐Ÿฆ๐Ÿ‹๐Ÿ’‰๐Ÿค–๐Ÿ‘ถ๐Ÿ๐Ÿ‘Ÿ๐Ÿ‘๐Ÿ”’๐Ÿ‘‚๐Ÿ”ฑ๐Ÿฅ‘๐ŸŒ๐Ÿงข๐ŸŸ๐Ÿ‘—๐ŸŽ๐Ÿ“–๐Ÿ‘๐ŸŠ๐Ÿซ๐ŸŒ•๐Ÿšฒ๐Ÿ๐Ÿ๐Ÿ“ก๐Ÿ๐Ÿ๐Ÿต๐Ÿšจ๐Ÿœ๐Ÿ‘ ๐ŸŽ๐Ÿฅ๐Ÿฆ‹

To Reproduce Steps to reproduce the behavior:

  1. Go to tari universe & copy the seed phrase from the Wallet section of settings
  2. On your Android device, install the Tari Aurora app
  3. Select Restore existing wallet
  4. Select the option to restore wallett via seed phrase
  5. Paste in the seed phrase from tari universe
  6. Once the wallet is restored on Aurora, view the wallet address on the home page and compare it to the Tari wallet address on Tari universe
  7. User can go to Settings on the Aurora anc click on the address there to view as well

Expected behavior As a user I should see the same address on my Aurora app as I see it on Tari universe

Screenshots photo_2024-10-09 13 46 29

Screenshot 2024-10-09 at 13 46 06

Desktop (please complete the following information):

Smartphone (please complete the following information):

stringhandler commented 1 month ago

putting in Blocked for now. Need to find a way to communicate that these are the same

SWvheerden commented 1 month ago

The reason the address differs is due the second char or byte.

๐Ÿ“Ÿ = 1 ๐ŸŒŠ = 3

1 means the address only supports 1-sided payments, whereas 3 means it supports 1-sided and interactive.

So the current display of the addresses are correct. But we need to increase user communication as to why the 2 addresses don't align 100%