search

tarides / dune-release

Streamlining the release of dune packages to opam
ISC License
114 stars 38 forks source link

Use project name for PR title and branch #465

Closed emillon closed 1 year ago

emillon commented 1 year ago

If we're submitting a PR for several packages, this uses "project name (N packages)" as PR title, and the project name is used for the branch. Previously the branch was taken from the shortest package name.

emillon commented 1 year ago

Ping @Leonidas-from-XIV In addition, we should use the former strategy when -p is passed. What is the good way to determine that?

emillon commented 1 year ago

NB the description in the PR is still wrong, it says "XDG Base Directory Specification" for dune.

Leonidas-from-XIV commented 1 year ago

I've added some code to handle -p (it's not very nice but the whole code packaging code is an utter mess).

The issue why it picks the description of XDG is because it uses Pkg.opam_descr is because it uses List.hd pkgs and that is of course utterly random and wrong. I wonder if we should revive #447 to clean up, because attempting to fix this here is just patching leaks.

emillon commented 1 year ago

Ah, I didn't see your comment about #447 so I implemented the "find the main package" in a different way. Let me know what you think (I used this for https://github.com/ocaml/opam-repository/pull/23748)

Leonidas-from-XIV commented 1 year ago

I guess this works as well. It is better than the status quo and if we realize this has some particular issues it can be fixed up later on. It does need a changelog entry though.

Closes #447. (Wonder if this works from a comment?)