search

tarides / dune-release

Streamlining the release of dune packages to opam
ISC License
114 stars 38 forks source link

Upgrade to ocamlformat 0.26.0 #478

Closed Julow closed 1 year ago

Julow commented 1 year ago

Mostly due to the change in indentation of a let or if inside parentheses.

The aim of this commit is to gather feedback.

Changelog can be found here: https://github.com/ocaml-ppx/ocamlformat/blob/main/CHANGES.md

Leonidas-from-XIV commented 1 year ago

Thanks @Julow!

My personal, very subjective opinion is that I like the change since I find if-then-else overall rather messy and hard to read so this is a welcome improvement. All the changed blocks read better than before as it is more apparent what is part of which branch of the if.

Can you ping me when a final version is released? I'd welcome upgrading to the new version and reformatting the source code.

Julow commented 1 year ago

Thanks for the feedback! I'll update this PR when the release is ready.

Julow commented 1 year ago

OCamlformat 0.26.0 has been released! This PR can be merged (not squashed due to .git-blame-ignore-revs) or closed if it's a bit too early to upgrade.