search

tarides / ocaml-platform-installer

The best way for developers to write software in OCaml
ISC License
61 stars 8 forks source link

Update the tool list #107

Closed Julow closed 1 year ago

Julow commented 2 years ago

Update the list according to https://github.com/ocaml/ocaml.org/pull/571, "deprecate" and "sustain" packages are not included.

panglesd commented 2 years ago

I don't think this is sufficient: for instance, opam-publish has the flags: plugin which is necessary to call it using opam publish.

Moreover, the CI fails at the installation of opam-publish, so we need to investigate!

Julow commented 2 years ago

As we investigated offline with @panglesd, the CI is failed because opam-publish has new external dependencies.

We discovered an other problem however, opam-publish has too many dependencies and takes a lot of time and bandwidth to be built in the sandbox. We thought of a new optimization (https://github.com/tarides/ocaml-platform-installer/issues/109) but the packages still have to be built once.

@tmattio What do you think of removing opam-publish and dune-release from the installer to improve speed ? I don't expect these packages to be useful to beginners or to be useful in many copies in all my switches.

Julow commented 2 years ago

The list of system dependencies in the README is not uptodate.

tmattio commented 2 years ago

@tmattio What do you think of removing opam-publish and dune-release from the installer to improve speed ? I don't expect these packages to be useful to beginners or to be useful in many copies in all my switches.

I'd suggest implementing the correct behaviour (i.e. installing all the Platform tools) first, and then worrying about optimising the installation. IMO it's better to tell users "go take a cup of coffee, this might take a few minutes" than to add steps and complexity to the workflows by not installing any tools to release packages on opam.

panglesd commented 2 years ago

I think ocaml-platform's man page as well as the README should also be updated!

Julow commented 2 years ago

I updated the README and the help. However, I do not agree with your last message Thibaut.

Speed was one of the goal, so slowing down the setup significantly to install a release tool might not be the obviously correct behavior. I don't think the installer main goal is to install "all" platform tools. At least in the first version we are trying to make, it is the opposite: to install tools useful to beginner, quickly.

panglesd commented 2 years ago

I rebased and removed utop from the installed tool: without a relocatable compiler, it would be too hard to have it installed with the installer.

panglesd commented 1 year ago

I also removed mdx which also suffers from non-relocatability/the removal of the compiler after the sandbox is no longer in use.

Julow commented 1 year ago

Let's close this.