search

tarides / ocaml-platform-installer

The best way for developers to write software in OCaml
ISC License
61 stars 8 forks source link

Use a temporary cache repo in case of pinned compiler #115

Closed Julow closed 2 years ago

Julow commented 2 years ago

Tools built on a pinned compilers need to be stored on a repository in order to be installed back in the user's switch. The cache repository was used for this, which contradicts the restriction that the cache isn't used with pinned compiler and might be unsafe.

Use a new temporary repository to make sure that these packages don't leak into the global cache. It is created on the fly and removed when it's no longer needed.

Packages that don't depend on the version of OCaml are no longer pulled from the cache in this case. This could be added back with more code and more bugs. What do you think ?

Julow commented 2 years ago

This should fix https://github.com/tarides/ocaml-platform-installer/issues/114

panglesd commented 2 years ago

Let's merge!