search

tarides / ocaml-platform-installer

The best way for developers to write software in OCaml
ISC License
61 stars 8 forks source link

Install the latest released version of opam #119

Closed punchagan closed 2 years ago

punchagan commented 2 years ago

Updates the make_installer.sh to create an installer which installs the latest released version of opam.

This is a crude version, and I guess this would need more testing. I'm happy to improve on this PR, based on suggestions and reviews.

Closes #100

panglesd commented 2 years ago

Now that I think a little bit more about it, it could be nice to add a test before releasing with the latest version of opam that everything works (even though, by opam design, it should be retrocompatible).

Basically, you would need to copy the Dockerfile.installl file in the test/dockerfiles folder, name it something something along the lines of Dockerfile.install-with-latest-opam, and replace the installation of opam through the package manager by an installation from the opam binary distribution installation script. Finally, you would need to add the new test in .github/workflows/build.yaml, similarly to other tests.

You can make the test run only on release with this if value. Anyway, at some point we'll have to sort which tests to run when, but let's keep that for another PR.

If you don't have time I can easily add the test myself to the PR. Just tell me. In any case, thanks for your contribution!

punchagan commented 2 years ago

Now that I think a little bit more about it, it could be nice to add a test before releasing with the latest version of opam that everything works (even though, by opam design, it should be retrocompatible).

Thanks for your detailed instructions on how to write a test. I've now added a test, and the build passes. :)

panglesd commented 2 years ago

Great! Let's merge!