tarides / ocaml-platform-installer

The best way for developers to write software in OCaml
ISC License
60 stars 8 forks source link

Don't skip installing if the installed version does not satisfy the request #127

Closed Julow closed 1 year ago

Julow commented 1 year ago

Fix https://github.com/tarides/ocaml-platform-installer/issues/126

Installing a tool was skipped if it was already installed on the current switch, regardless of its required version. This only affected ocamlformat.

I moved some code for readability, which was being re-indented anyway.

panglesd commented 1 year ago

As mentioned in https://github.com/tarides/ocaml-platform-installer/issues/126#issuecomment-1280849784, I am not keen on introducing this feature! I'll look at the code if you really think that it does more good than bad.

Julow commented 1 year ago

I'll merge this as I believe the semantic is better: the last request wins, we install what the user expects.