search

tarides / ocaml-platform-installer

The best way for developers to write software in OCaml
ISC License
60 stars 8 forks source link

Don't persist sandbox compiler packages #136

Closed Julow closed 1 year ago

Julow commented 1 year ago

Might fix https://github.com/tarides/ocaml-platform-installer/issues/130

These packages are only needed while building in the sandbox switch and are not costly to re-create every time. This eliminate bugs due to outdated persisted data.

'Sandbox_compiler_package' is rewritten in the "with_resource" style to accomodate the new 'with_sandbox_compiler_repo' function. This remove the tedious 'deinit' code and the need to add more book keeping for the new temporary directory.

Julow commented 1 year ago

Ready for review. This is not blocked by the other repo discussion.

panglesd commented 1 year ago

Let's merge as soon as CI is green.