search

tarides / ocaml-platform-installer

The best way for developers to write software in OCaml
ISC License
60 stars 8 forks source link

Fix crash when there's nothing to install #142

Closed Julow closed 1 year ago

Julow commented 1 year ago

Make sure not to call 'Opam.install' with an empty list, which results in an error. Messages are planned for this situation but the error happen before they could be printed.

Julow commented 1 year ago

I'm not adding a test for this because I think the heavy docker tests wouldn't be a good fit. We need a quicker test framework first.

Julow commented 1 year ago

I'll add the changelog after the CI has run to avoid wasting an hour and I'll cancel the jobs triggered after that.