search

tarides / ocaml-platform-installer

The best way for developers to write software in OCaml
ISC License
61 stars 8 forks source link

Fix pr number ci #68

Closed Julow closed 2 years ago

Julow commented 2 years ago

The pr-number CI action requires a specific name for the changelog file. I don't have a strong opinion but @Leonidas-from-XIV does it seems.

Leonidas-from-XIV commented 2 years ago

I don't necessarily have a strong opinion on it, CHANGES.md is just the format we use for packages that we use for dune-release hence the action was written that way for simplicity (in the spirit of KISS)

It could be made configurable or automatically discover the changelog file, but thus far there was just no need. If you'd think more flexibility would be useful I'll gladly look into making the action more useful for your purposes.

Julow commented 2 years ago

A standard name is good. It was annoying to find out after I chose a different name but that was my fault. Sorry for the unnecessary ping.