search

tarides / opam-monorepo

Assemble dune workspaces to build your project and its dependencies as a whole
ISC License
130 stars 27 forks source link

Allow resolving unprefixed refs #332

Closed Leonidas-from-XIV closed 2 years ago

Leonidas-from-XIV commented 2 years ago

When using a pinned dependency the refs might not have a prefix (e.g. HEAD is a plain ref) thus they wouldn't have been found when attempting to resolve the refs.

Closes #326

samoht commented 2 years ago

Could you add a test-case to ensure we don't introduce future regressions there? I'm not sure I understand this logic either.

Leonidas-from-XIV commented 2 years ago

@samoht I've added a test. It's a bit ugly since it messes with the global OPAM state (by creating a pin called opam-monorepo-test-other but the original report can only be reproduced with pins.