search

tarides / opam-monorepo

Assemble dune workspaces to build your project and its dependencies as a whole
ISC License
130 stars 27 forks source link

`opam monorepo lock` fails to parse git repos #334

Closed RyanGibb closed 2 years ago

RyanGibb commented 2 years ago 
~/projects/opam-monorepo/_build/default/bin/opam_monorepo.exe lock hello-unix --opam-repositories '[git+https://github.com/ocaml/opam-repositories]'
==> Using 1 locally scanned package as the target.
opam_monorepo.exe: [ERROR] Only non git, local filesystem URLs (file://) are supported at the moment
Leonidas-from-XIV commented 2 years ago

It's merged but not released yet.

RyanGibb commented 2 years ago

Gah I was using the wrong branch! You're absolutely right.

Strangely it prompts for my GitHub credentials (and fails to authenticate with them) when using the most recent branch though.

Leonidas-from-XIV commented 2 years ago

That's odd! Are you sure the repo you're trying to use is public? Or try the SSH URI?

RyanGibb commented 2 years ago

Ah it's user error again 😭 I keep making the same typo because in doc/lock.mld https://github.com/ocaml/opam-repositories is used where I think it should be https://github.com/ocaml/opam-repository!

Leonidas-from-XIV commented 2 years ago

Oh, that's a good catch! If you have a moment, could you submit a PR please? It might be user error but it certainly is also a documentation error :sweat_smile:

RyanGibb commented 2 years ago

Done!