search

tariel36 / MAL-Unretard-Related-Entries

0 stars 1 forks source link

[Bug] Some pages don't unhide all entries #1

Closed Wulfson closed 2 months ago

Wulfson commented 3 months ago

Using Greasemonkey in Firefox, the script has a minor issue on particularly large lists, like the one found on the One Piece page.

one_piece

I was able to fix it by changing the Unfold code here: https://github.com/tariel36/MAL-Unretard-Related-Entries/blob/935f2646a6547340542b92effd08538482e9d889/MAL-Unretard-Related-Entries.user.js#L32-L34

to this:

  Array.from(document.getElementsByClassName("hide-entry")).forEach(function (el) {
    el.removeAttribute("style");
    el.classList.remove("hide-entry");
  });

I don't know if that has any other side-effects.

tariel36 commented 3 months ago

Thanks, I will have a loot at that within a week, as currently I'm a little busy with IRL matters.

tariel36 commented 2 months ago

@Wulfson In my Firefox (totally clean install) it worked without issues with old code for One Piece, but applied your fix anyway. Check if it works for you now (it should be version 1.0.2 or above).

Wulfson commented 2 months ago

It's actually broken entirely for me on 1.0.3...sticking these lines: https://github.com/tariel36/MAL-Unretard-Related-Entries/blob/master/MAL-Unretard-Related-Entries.user.js#L19-L22 into 1.0.1 works as expected, though

tariel36 commented 2 months ago

Can you provide error message if it exists?

Are you still testing on the One Piece link?

Do you have any other script or extension that may influence MAL source html? If so, please test on clean browser.

tariel36 commented 2 months ago

Closed for inactivity / not reproducible.