tarinoita / Spice-of-Life-Sweet-Potato

Motivating people to explore new foods with the potato, not the stick.
GNU Lesser General Public License v2.1
2 stars 6 forks source link

Feature Request: Compatibility with Some Assembly Required sandwiches #19

Open dther opened 1 year ago

dther commented 1 year ago

Hello! I've found an incompatibility that appears to be shared with all Spice of Life forks from Potato onwards. The oldest report of a similar issue is here, and I've reported it in another SOL fork I use, Apple Pie.

In short: Some mods introduce "composite" food items which store ingredients as an NBT tag containing a list. In the case of Some Assembly Required, this takes the form of sandwiches, but I imagine similar mods can be made using pizza toppings and the like.

The problem is that these composite foods all have a shared item ID (e.g., some_assembly_required:sandwich), meaning that they only count as one food item, no matter what combination or size the sandwich is. Fixing this would mean that FoodInstance should keep a copy of composite food's NBT tags, and use them as part of the hash function to determine if one sandwich is different from another. I would greatly appreciate a fix for this, as I'm working on a modpack which heavily features Create automation (which is a great way of making custom sandwiches).

Thanks for your time!